perf(cdk/overlay): add event listeners for overlay dispatchers outside of zone #23962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Nov 14, 2021
crisbeto
reviewed
Nov 14, 2021
crisbeto
reviewed
Nov 14, 2021
| @@ -28,7 +32,11 @@ export class OverlayKeyboardDispatcher extends BaseOverlayDispatcher { | |||
|
|
|||
| // Lazily start dispatcher once first overlay is added | |||
| if (!this._isAttached) { | |||
| this._document.body.addEventListener('keydown', this._keydownListener); | |||
| this._ngZone | |||
| ? this._ngZone.runOutsideAngular(() => | |||
There was a problem hiding this comment.
Can you use an if/else statement here, rather than the ternary? Also can you leave an @breaking-change note here as well? That way our tooling will pick it up when we're doing the breaking changes.
arturovt
changed the title
keydown listener outside of zone
crisbeto
added
action: merge
andrewseguin
added
needs rebase
and removed
cla: yes
zarend
added a commit
that referenced
this pull request
Feb 3, 2022
|
Hello @arturovt, this PR was reverted because it caused an issue internally. Could you please make a new PR with this change? That we can run a fresh presubmit check, then assess how best to proceed with this. |
|
Hey @zarend , alright. |
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
…s outside of zone (angular#23962)" (angular#24353) This reverts commit e761455.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OverlayKeyboardDispatcheradds akeydownevent listener, which causes Angular to run change detections on anykeydownevent, tho its listener may behave as a "noop" (e.g. if there're nokeydownEventsobservers).With these changes, the Angular zone will be re-entered only if there're any
keydownEventslisteners.