Skip to content

Conversation

GuilhermeRossato
Copy link
Contributor

…om getting-started guide

The mat-slider is invisible when value is 1 on the purple-green pre-built template after following the "getting started" guide. Since the white background is default nothing can be seen, which is especially bad for newbies.

This addresses a problem that causes the mat-slider from the Getting Started guide to be invisible even when perfectly following the steps, as shown below:

problematic demo

This is caused because the pre-build material theme purple-green.css has the following style to mat-slider's with min-value:

.mat-slider-min-value:not(.mat-slider-thumb-label-showing) .mat-slider-thumb {
    border-color: rgba(255,255,255,.3);
    background-color: transparent
}

Following the getting-started tutorial after this change yields this:
working demo

…ing-started guide

The mat-slider is invisible when value is 1 on the purple-green  pre-built template after following the "getting started" guide. Since the white background is default nothing can be seen, which is especially bad for newbies.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jelbourn jelbourn added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 30, 2021
@andrewseguin andrewseguin merged commit 74f18ed into angular:master Aug 11, 2021
andrewseguin pushed a commit that referenced this pull request Aug 11, 2021
#23276)

The mat-slider is invisible when value is 1 on the purple-green  pre-built template after following the "getting started" guide. Since the white background is default nothing can be seen, which is especially bad for newbies.

(cherry picked from commit 74f18ed)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants