Skip to content

test(ripple): refactor long-running unit test #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2016
Merged

test(ripple): refactor long-running unit test #2155

merged 1 commit into from
Dec 14, 2016

Conversation

crisbeto
Copy link
Member

Refactors a unit test that used to take 1.6s, due to it using a native setTimeout, by replacing the native timer with a flushable one.

Fixes #2097.

@crisbeto
test(ripple): refactor long-running unit test
3839627 
Refactors a unit test that used to take 1.6s, due to it using a native `setTimeout`, by replacing the native timer with a flushable one.

Fixes angular#2097.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 10, 2016
@belev belev mentioned this pull request Dec 10, 2016
Merged
EladBezalel added a commit to EladBezalel/material2 that referenced this pull request Dec 12, 2016
@EladBezalel
fix(tabs): observing tab header label changes to recalculate width
e56f38f 
- Uses observe-changes directive that emit an event when the mutation observer notifies a change

fixes angular#2155
@EladBezalel EladBezalel mentioned this pull request Dec 12, 2016
Merged
EladBezalel added a commit to EladBezalel/material2 that referenced this pull request Dec 12, 2016
@EladBezalel
fix(tabs): observing tab header label changes to recalculate width
6ed8bec 
- Uses observe-changes directive that emit an event when the mutation observer notifies a change

fixes angular#2155
@jelbourn
Copy link
Member

LGTM, thanks. I thought that fakeAsync wouldn't work because the setTimeout is outside the Angular zone, but I guess it works since it's still captured by the root zone.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 14, 2016
EladBezalel added a commit to EladBezalel/material2 that referenced this pull request Dec 14, 2016
@EladBezalel
fix(tabs): observing tab header label changes to recalculate width
3b4873b 
- Uses observe-changes directive that emit an event when the mutation observer notifies a change

fixes angular#2155
EladBezalel added a commit to EladBezalel/material2 that referenced this pull request Dec 14, 2016
@EladBezalel
fix(tabs): observing tab header label changes to recalculate width
650d09b 
- Uses observe-changes directive that emit an event when the mutation observer notifies a change

fixes angular#2155
EladBezalel added a commit to EladBezalel/material2 that referenced this pull request Dec 14, 2016
@EladBezalel
fix(tabs): observing tab header label changes to recalculate width
9b2404b 
- Uses observe-changes directive that emit an event when the mutation observer notifies a change

fixes angular#2155
EladBezalel added a commit to EladBezalel/material2 that referenced this pull request Dec 14, 2016
@EladBezalel
fix(tabs): observing tab header label changes to recalculate width
5fa3c58 
- Uses observe-changes directive that emit an event when the mutation observer notifies a change

fixes angular#2155
@jelbourn jelbourn merged commit b3e21b8 into angular:master Dec 14, 2016
EladBezalel added a commit to EladBezalel/material2 that referenced this pull request Dec 16, 2016
@EladBezalel
fix(tabs): observing tab header label changes to recalculate width
f839831 
- Uses observe-changes directive that emit an event when the mutation observer notifies a change

fixes angular#2155
EladBezalel added a commit to EladBezalel/material2 that referenced this pull request Dec 17, 2016
@EladBezalel
fix(tabs): observing tab header label changes to recalculate width
56d06b1 
- Uses observe-changes directive that emit an event when the mutation observer notifies a change

fixes angular#2155
EladBezalel added a commit to EladBezalel/material2 that referenced this pull request Dec 19, 2016
@EladBezalel
fix(tabs): observing tab header label changes to recalculate width
d0b4fc8 
- Uses observe-changes directive that emit an event when the mutation observer notifies a change

fixes angular#2155
EladBezalel added a commit to EladBezalel/material2 that referenced this pull request Dec 20, 2016
@EladBezalel
fix(tabs): observing tab header label changes to recalculate width
c8a6e6c 
- Uses observe-changes directive that emit an event when the mutation observer notifies a change

fixes angular#2155
jelbourn pushed a commit that referenced this pull request Dec 20, 2016
@EladBezalel @jelbourn
fix(tabs): observing tab header label changes to recalculate width (#…
7ab4430 
…2186)

- Uses observe-changes directive that emit an event when the mutation observer notifies a change

fixes #2155
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single ripple unit test uses a 1600ms timeout
3 participants
@crisbeto @jelbourn @googlebot