Skip to content

fix(material-experimental/mdc-snack-bar): button pushed outside container #20696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2020
Merged

fix(material-experimental/mdc-snack-bar): button pushed outside container #20696

merged 1 commit into from
Oct 1, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 1, 2020

Fixes a regression from #20690 that caused the snack bar button to be pushed outside of the container.

@crisbeto
fix(material-experimental/mdc-snack-bar): button pushed outside conta…
656e1df 
…iner

Fixes a regression from angular#20690 that caused the snack bar button to be pushed outside of the container.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Oct 1, 2020
@crisbeto crisbeto requested a review from andrewseguin as a code owner October 1, 2020 05:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 1, 2020
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 1, 2020
@mmalerba mmalerba merged commit 50d3f29 into angular:master Oct 1, 2020
mmalerba pushed a commit that referenced this pull request Oct 1, 2020
@crisbeto @mmalerba
fix(material-experimental/mdc-snack-bar): button pushed outside conta…
c5fd98a 
…iner (#20696)

Fixes a regression from #20690 that caused the snack bar button to be pushed outside of the container.

(cherry picked from commit 50d3f29)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @googlebot @mmalerba