Skip to content

Conversation

@vanessanschmitt
Copy link
Contributor

If the items QueryList changes such the previous activeItem is no
longer in it, reset activeItem and activeItemIndex to null and -1.
This will allow code like:
if (keyManager.activeItem) {
// Do something with the active item
}
to work properly by not operating on an item that has been removed.

If the items QueryList changes such the previous activeItem is no
longer in it, reset activeItem and activeItemIndex to null and -1.
This will allow code like:
if (keyManager.activeItem) {
  // Do something with the active item
}
to work properly by not operating on an item that has been removed.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 12, 2020
@vanessanschmitt
Copy link
Contributor Author

Looks like this broke some tests! Will investigate.

@vanessanschmitt vanessanschmitt marked this pull request as draft August 12, 2020 19:10
@crisbeto
Copy link
Member

There's an existing PR that solves this issue already #20008.

@vanessanschmitt
Copy link
Contributor Author

Awesome thank you!!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants