feat(dialog): add the ability to close all dialogs #1965
Merged
+47
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 29, 2016
src/lib/dialog/dialog.ts
Outdated
| if (index > -1) { | ||
| this._openDialogs.splice(index, 1); | ||
| } | ||
| }); |
There was a problem hiding this comment.
This would be a bit cleaner with another method:
dialogRef.afterClosed().subscribe(() => this._removeOpenDialog(dialogRef));|
|
||
| while (i--) { | ||
| this._openDialogs[i].close(); | ||
| } |
There was a problem hiding this comment.
I think this needs a comment like
// The `_openDialogs` property isn't updated after close until the rxjs subscription
// runs on the next microtask, so we loop through all of them and call close without
// assuming that they'll be removed from the list instantaneously. 
crisbeto
force-pushed
the
dialog-close-all
branch
from
fad16b6 to
75ac68e
Compare
Adds a `closeAll` method that closes all of the currently-open dialogs.
crisbeto
force-pushed
the
dialog-close-all
branch
from
75ac68e to
6d21a28
Compare
|
Addressed the feedback and rebased. |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
closeAllmethod that closes all of the currently-open dialogs.