Skip to content

refactor(tooltip): change deprecated APIs for version 10 #19364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 14, 2020

Changes an API that was marked for deprecation in v10.

BREAKING CHANGES:

  • The _hammerLoader parameter has been removed from the MatTooltip constructor.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 14, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 14, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 14, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 14, 2020
@jelbourn
Copy link
Member

@crisbeto passes presubmit, just needs rebase

@crisbeto crisbeto force-pushed the tooltip-v10-breaking-changes branch from 0abbe06 to 0017fd2 Compare May 21, 2020 07:01
@crisbeto
Copy link
Member Author

Rebased.

Changes an API that was marked for deprecation in v10.

BREAKING CHANGES:
* The `_hammerLoader` paramter has been removed from the `MatTooltip` constructor.
@crisbeto crisbeto force-pushed the tooltip-v10-breaking-changes branch from 0017fd2 to 209bea5 Compare May 26, 2020 17:26
@jelbourn jelbourn merged commit e6e6d6f into angular:master May 26, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants