Skip to content

refactor(platform): change deprecated APIs for version 10 #19347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2020
Merged

refactor(platform): change deprecated APIs for version 10 #19347

merged 1 commit into from
May 26, 2020

Conversation

crisbeto
Copy link
Member

Changes the APIs that were deprecated for v10 in the cdk/platform module.

BREAKING CHANGES:

  • The _platformId parameter in the Platform constructor is now required.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 13, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 13, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 13, 2020
devversion
devversion approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. One comment for the platform test changes.

@crisbeto crisbeto force-pushed the platform-v10-breaking-changes branch from 13900b1 to 001fa3e Compare May 13, 2020 19:14
@crisbeto
refactor(platform): change deprecated APIs for version 10
bfa1bbc 
Changes the APIs that were deprecated for v10 in the `cdk/platform` module.

BREAKING CHANGES:
* The `_platformId` parameter in the `Platform` constructor is now required.
@crisbeto crisbeto force-pushed the platform-v10-breaking-changes branch from 001fa3e to bfa1bbc Compare May 13, 2020 19:17
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 13, 2020
jelbourn
jelbourn approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 2defaf7 into angular:master May 26, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @googlebot