Skip to content

fix(button): remove disabled attribute when disabled value is false… #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2016
Merged

fix(button): remove disabled attribute when disabled value is false… #1789

merged 1 commit into from
Nov 11, 2016

Conversation

tinayuangao
Copy link
Contributor

… for MdAnchor

Caused by #1778

R: @jelbourn

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 9, 2016
@tinayuangao tinayuangao added pr: needs review and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Nov 9, 2016
jelbourn
jelbourn reviewed Nov 9, 2016
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test for this as well?

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 9, 2016
@tinayuangao
Copy link
Contributor Author

Test added

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 10, 2016
@Splaktar Splaktar mentioned this pull request Nov 11, 2016
Closed
@Splaktar
Copy link
Contributor

Fixes #1801.

@jelbourn jelbourn merged commit 716372b into angular:master Nov 11, 2016
@kyleledbetter kyleledbetter mentioned this pull request Nov 14, 2016
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tinayuangao @jelbourn @Splaktar @googlebot