feat(snackbar): don't require a ViewContainerRef #1783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
josephperrott
requested changes
Nov 9, 2016
src/lib/snack-bar/snack-bar.ts
Outdated
| */ | ||
| open(message: string, actionLabel: string, | ||
| config: MdSnackBarConfig): MdSnackBarRef<SimpleSnackBar> { | ||
| open(message: string, action = '', config?: MdSnackBarConfig): MdSnackBarRef<SimpleSnackBar> { |
There was a problem hiding this comment.
Is there a reason to not just set a default config of {}?
open(message: string, action = '', config: MdSnackBarConfig = {})...
src/lib/snack-bar/snack-bar.ts
Outdated
| * @param config The configuration to which the defaults will be applied. | ||
| * @returns The new configuration object with defaults applied. | ||
| */ | ||
| private _applyConfigDefaults(config: MdSnackBarConfig): MdSnackBarConfig { |
There was a problem hiding this comment.
should this be a module level method, or static even?
There was a problem hiding this comment.
Changed to non-exported module function.
rolandjitsu
pushed a commit
to rolandjitsu/material2
that referenced
this pull request
Nov 10, 2016
* feat(snackbar): don't require a ViewContainerRef * default config, module method
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @josephperrott or @kara
Also lets you use an object literal as the config.