refactor: annotate remaining base classes with @directive for ivy #17279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn and
a team
as code owners
googlebot
added
the
cla: yes
devversion
added
blocked
googlebot
added
the
cla: yes
This comment has been minimized.
This comment has been minimized.
devversion
force-pushed
the
build/lint-rule-undecorated-classes-with-ng-fields
branch
4 times, most recently
from
98a78e4 to
868c24b
Compare
devversion
force-pushed
the
build/lint-rule-undecorated-classes-with-ng-fields
branch
from
868c24b to
b9944b5
Compare
josephperrott
approved these changes
Oct 3, 2019
devversion
added
the
P1
…rated Read more about this here: https://hackmd.io/vuQfavzfRG6KUCtU7oK_EA.
These base classes define class members with Angular features. Therefore they need to be decorated with `@Directive()` so that the classes can be extended in Ivy. This is an official migration that will be performed for CLI applications in version 9. angular/angular#32590.
devversion
force-pushed
the
build/lint-rule-undecorated-classes-with-ng-fields
branch
from
b9944b5 to
0832020
Compare
devversion
removed
the
blocked
devversion
changed the title
devversion
changed the title
Splaktar
reviewed
Oct 3, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some base classes define class members with Angular features. Therefore
they need to be decorated with
@directive()so that the classes can beextended in Ivy.
This is an official migration that will be performed for CLI
applications in version 9. angular/angular#32590.
Most of these classes do not cause issues yet because the removal of
ngBaseDefhas not happened yet, but it is planned.. hence the actual migration in
@angular/core.