feat(material-experimental): add test harnesses for slide-toggle #16545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@jelbourn That actually looks like a bug. I just reproduced it in a StackBlitz (see here). We need to provide the proper checkbox validator when required. The default required validator just asserts that the value is non-undefined.. which is always the case for a boolean state. Here is a PR that should unblock this: #16547 |
jelbourn
force-pushed
the
slide-toggle-harness
branch
2 times, most recently
from
e9a1461 to
7b0dfb7
Compare
This is almost done, but for some reason the `ng-invalid` class is *not* being added to the slide-toggle, making the `isValid` test fail.
jelbourn
force-pushed
the
slide-toggle-harness
branch
from
7b0dfb7 to
1c5eb32
Compare
jelbourn
changed the title
jelbourn
added
pr: merge safe
target: patch
mmalerba
approved these changes
Jul 25, 2019
andrewseguin
pushed a commit
that referenced
this pull request
Jul 29, 2019
It slides, it toggles, it makes julienne fries.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It slides, it toggles, it makes julienne fries.