-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(drag-drop): fix drag start delay behavior to allow scrolling (#16224) #16537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ular#16224) The current implementation of the drag start delay does not allow scrolling on iOS devices. Also, once the element has been scrolled once, the scrolling is never reenabled. In order to fix this issue, we prevent default behaviour of pointer events fired after the drag sequence has been started instead of initialized. Also, we toggle native drag interactions when the drag sequence is ended.
Actually it seems like there is an issue with my solution. Sometimes, when you drag, it scrolls. |
@Aboisier, @crisbesto: at the moment, scrolling is not possible on iOS devices if @Aboisier: Whats the state of this PR? Can I help you somehow? Are you still working on fixing the drag scroll behavior you mentioned in your last comment? Edit: for everyone else: use a |
Hey @trampi , I don't think I will work on this PR in the near future. It seems like a change has been introduced between 8.0.2 and 8.1.0 and it's breaking my fix, so we are currently using a fork of 8.0.2 on which we applied #16228 and this PR. It's kind of stableish. You're welcome to continue the work on this PR! |
Hi @Aboisier, I would love to but I lack the time, experience and knowledge about CDK. Thank you for your feedback! |
Closing since the relevant issue (#17923) has already been fixed |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I tried fixing the scrolling issue on mobile devices with my previous PR (#16228), but it did not work on iOS. There was also a bug with scrolling after the item has been dragged once. The native drag interactions were not toggled when the drag sequence is ended.
In order to fix the iOS issue, we prevent default behaviour of pointer events fired after
the drag sequence has been started instead of only initialized.