fix(popover-edit): unable to close by pressing enter on some screen readers #16466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
|
Is it possible to continue using keyup? That's more consistent with how things like form submission normally work. |
kseamon
reviewed
Jul 6, 2019
crisbeto
force-pushed
the
popover-edit-focus-management
branch
from
67aebe4 to
700881e
Compare
|
We can't use |
crisbeto
changed the title
jelbourn
approved these changes
Jul 24, 2019
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto just needs rebase |
|
Rebased. |
crisbeto
force-pushed
the
popover-edit-focus-management
branch
from
700881e to
8c52497
Compare
…n readers * Fixes not being able to close the overlay by pressing Enter on the close button when using some screen readers (tested on NVDA, but I expect it to work similarly in others). The issue comes from the fact that we keep track of whether the user is pressing Enter through `keyup` and `keydown` events, however screen readers emit fake `click` events on buttons instead of `keyup` and `keydown`. * Fixes not being able to close the overlay by clicking on the close button with a mouse, if the keyboard was used to reach the button (e.g. by tabbing to it). This issue also comes from the fact that we were keeping track of keyboard events and assuming that the user will continue using a keyboard to close the overlay. * Gets rid of a bunch of keyboard event tracking logic. **Disclaimer:** I had to introduce a `setTimeout` when trapping focus inside the overlay, in order to prevent the form inside the overlay from being submitted immediately when opening through a `keydown` on Enter. From what I can tell this shouldn't really have an effect on existing tests since we have other timers that are running at the same time.
crisbeto
force-pushed
the
popover-edit-focus-management
branch
from
8c52497 to
7377a62
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Jul 29, 2019
…n readers (#16466) * Fixes not being able to close the overlay by pressing Enter on the close button when using some screen readers (tested on NVDA, but I expect it to work similarly in others). The issue comes from the fact that we keep track of whether the user is pressing Enter through `keyup` and `keydown` events, however screen readers emit fake `click` events on buttons instead of `keyup` and `keydown`. * Fixes not being able to close the overlay by clicking on the close button with a mouse, if the keyboard was used to reach the button (e.g. by tabbing to it). This issue also comes from the fact that we were keeping track of keyboard events and assuming that the user will continue using a keyboard to close the overlay. * Gets rid of a bunch of keyboard event tracking logic. **Disclaimer:** I had to introduce a `setTimeout` when trapping focus inside the overlay, in order to prevent the form inside the overlay from being submitted immediately when opening through a `keydown` on Enter. From what I can tell this shouldn't really have an effect on existing tests since we have other timers that are running at the same time.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keyupandkeydownevents, however screen readers emit fakeclickevents on buttons instead ofkeyupandkeydown.Disclaimer: I had to introduce a
setTimeoutwhen trapping focus inside the overlay, in order to prevent the form inside the overlay from being submitted immediately when opening through akeydownon Enter. From what I can tell this shouldn't really have an effect on existing tests since we have other timers that are running at the same time.