Skip to content

feat(dialog): allow for custom ComponentFactoryResolver to be passed in #16437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2019
Merged

feat(dialog): allow for custom ComponentFactoryResolver to be passed in #16437

merged 1 commit into from
Jul 19, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 3, 2019

Allows for a different ComponentFactoryResolver to be passed in when creating a dialog.

Fixes #16431.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release labels Jul 3, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner July 3, 2019 14:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 3, 2019
@jelbourn
Copy link
Member

jelbourn commented Jul 3, 2019

Should we do this if ComponentFactoryResolver stops being a necessary thing under ivy?

@crisbeto
feat(dialog): allow for custom ComponentFactoryResolver to be passed in
081dd89 
Allows for a different `ComponentFactoryResolver` to be passed in when creating a dialog.

Fixes angular#16431.
@crisbeto crisbeto force-pushed the 16431/dialog-cfr branch from 145e605 to 081dd89 Compare July 3, 2019 20:24
@crisbeto
Copy link
Member Author

crisbeto commented Jul 3, 2019

The way I'm looking at it is that it'll be a noop in Ivy so it won't break anybody, and people on ViewEngine will still be able to use it. It also doesn't take any effort on our end to maintain.

jelbourn
jelbourn approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 8, 2019
@jelbourn jelbourn merged commit 565bd7d into angular:master Jul 19, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow componentFactoryResolver to be passed to MatDialog.open
3 participants
@crisbeto @jelbourn @googlebot