Skip to content

feat(datepicker): add aria-role button to year cells #16406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(datepicker): add aria-role button to year cells #16406

wants to merge 1 commit into from

Conversation

jerome-nelson
Copy link
Contributor

@jerome-nelson jerome-nelson commented Jun 28, 2019 •
edited
Loading

fixes #16402

(possibly) - what is the actual result I should hear in NVDA?

another PR already fixes issue

@jerome-nelson jerome-nelson requested a review from mmalerba as a code owner June 28, 2019 15:40
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 28, 2019
@jerome-nelson jerome-nelson deleted the feature/datepicker-button-yearview branch June 28, 2019 15:46
jelbourn pushed a commit that referenced this pull request Jul 17, 2019
@wnvko @jelbourn
feat(datepicker): remove mat-button and add only role button, #16406
dbf949b
jelbourn pushed a commit that referenced this pull request Jul 19, 2019
@wnvko @jelbourn
Change date picker cells to buttons (#16402)
ad09bb2 
* fix(matCalendar): make cell content button, #16356

* test(navDatePicker): fix failing tests, #16356

* chore(navDatePicker): change initial to 0 for IE, #16356

* feat(datepicker): remove mat-button and add only role button, #16406
andrewseguin pushed a commit that referenced this pull request Jul 29, 2019
@wnvko @andrewseguin
Change date picker cells to buttons (#16402)
ce1844f 
* fix(matCalendar): make cell content button, #16356

* test(navDatePicker): fix failing tests, #16356

* chore(navDatePicker): change initial to 0 for IE, #16356

* feat(datepicker): remove mat-button and add only role button, #16406
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerome-nelson @googlebot