feat(drag-drop): add support for automatic scrolling #16382
Conversation
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
13588/drag-drop-viewport-scroll
branch
2 times, most recently
from
aa93d82 to
b4be85f
Compare
crisbeto
added
P2
|
Just approve it! Can't wait! |
|
is there any live demo? |
| this._dropContainer._stopScrolling(); | ||
| this._animatePreviewToPlaceholder().then(() => { | ||
| this._cleanupDragArtifacts(event); | ||
| this._dragDropRegistry.stopDragging(this); |
There was a problem hiding this comment.
Would it make sense for stopDragging to cause _cleanupDragArtifacts in itself?
There was a problem hiding this comment.
_cleanupDragArtifacts is private to the DragRef whereas stopDragging is in the DragDropRegistry. Also this logic isn't new, I just moved it around so it's easier to follow.
| const clientRect = {width, height, top: 0, right: width, bottom: height, left: 0}; | ||
| verticalScrollDirection = getVerticalScrollDirection(clientRect, pointerY); | ||
| horizontalScrollDirection = getHorizontalScrollDirection(clientRect, pointerX); | ||
| scrollNode = window; |
There was a problem hiding this comment.
Was there some issue about window not existing in some environment? I vaguely recall this but don't remember the details
There was a problem hiding this comment.
It doesn't exist during server-side rendering, but the only way the user can hit this code path is after a specifier sequence of mousedown and mousemove events hence why I haven't added extra guards around it.
* Adds support for automatically scrolling either the list or the viewport when the user's cursor gets within a certain threshold of the edges (currently within 5% inside and outside). * Handles changes to the scroll position of both the list and the viewport while the user is dragging. Previous our positioning would break down and we'd emit incorrect data. * No longer blocks the mouse wheel scrolling while the user is dragging. * Allows the consumer to opt out of the automatic scrolling. Fixes angular#13588.
crisbeto
force-pushed
the
13588/drag-drop-viewport-scroll
branch
from
b4be85f to
156361a
Compare
|
Reworked based on the feedback @jelbourn. |
|
It looks nice! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #13588.
