component: MdInput #161
component: MdInput #161
Conversation
googlebot
added
the
cla: yes
hansl
force-pushed
the
md-input
branch
9 times, most recently
from
2b58ce3 to
de51aed
Compare
| const defaultValue = target[key]; | ||
|
|
||
| // Use a fallback if Symbol isn't available. | ||
| const localKey = isPresent(Symbol) ? Symbol(key) : `@@$_${key}`; |
There was a problem hiding this comment.
adding special characters such as @@ makes the object into slow object. Better to use __private_symbol_ or something like that.
There was a problem hiding this comment.
Done. Firefox used to support @@ as a prefix for symbols, thus my usage of this.
hansl
force-pushed
the
md-input
branch
3 times, most recently
from
62e2d0a to
7718712
Compare
hansl
force-pushed
the
md-input
branch
4 times, most recently
from
b132570 to
19810be
Compare
| export class MdInput implements ControlValueAccessor { | ||
| private _empty: boolean = true; | ||
| private _focused: boolean = false; | ||
| private _onTouched: () => void = () => {}; |
There was a problem hiding this comment.
Does ng2 provide a noop( ) function like ng1 ?
hansl
force-pushed
the
md-input
branch
3 times, most recently
from
a5fa97a to
a384a3a
Compare
| ## Type | ||
|
|
||
| At the time of writing this README, the `[type]` attribute is copied to the actual `<input>` element in the `<md-input>`. Therefore, the valid types and behavior of those are the ones supported by your browser. | ||
|
|
| color: md-color($md-primary); | ||
| } | ||
|
|
||
| md-card { |
|
Done w/ second pass |
hansl
force-pushed
the
md-input
branch
7 times, most recently
from
420e592 to
e218b12
Compare
|
PTAL. |
hansl
force-pushed
the
md-input
branch
2 times, most recently
from
35789d3 to
c87cdb0
Compare
| [class.md-accent]="dividerColor == 'accent'"></span> | ||
| </div> | ||
|
|
||
| <div *ngIf="hintLabel != ''" class="md-hint">{{hintLabel}}</div> |
There was a problem hiding this comment.
No actions now, but my gut is worried about each input having ~25 bindings. Something to explore later.
(I could just be clinging to Angular 1 performance concerns, though)
There was a problem hiding this comment.
Noted. There should be a greater task of performance checks AND visual checking before full release. In beta maybe.
hansl
force-pushed
the
md-input
branch
4 times, most recently
from
33eb683 to
3bc1606
Compare
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.