Skip to content

md-input #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jelbourn opened this issue Feb 27, 2016 · 16 comments
Closed

md-input #116

jelbourn opened this issue Feb 27, 2016 · 16 comments
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix new component This issue is tracking a new component to be added to the library
Milestone

Comments

@jelbourn
Copy link
Member

Blocked on #84

@jelbourn jelbourn added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Feb 27, 2016
@jelbourn jelbourn added this to the before beta milestone Feb 27, 2016
@jelbourn jelbourn changed the title mdInput md-input Feb 27, 2016
@jelbourn jelbourn added the new component This issue is tracking a new component to be added to the library label Feb 27, 2016
@ekarlso
Copy link

ekarlso commented Mar 16, 2016

Hi, is there any eta on this part?

@jelbourn
Copy link
Member Author

@ekarlso it's in progress #161

@jelbourn jelbourn modified the milestones: alpha.2, before beta Mar 17, 2016
@hansl
Copy link
Contributor

hansl commented Mar 31, 2016

Merged #161 . I'm going to close this and open issues for missing parts.

@hansl hansl closed this as completed Mar 31, 2016
@fxck
Copy link
Contributor

fxck commented Apr 7, 2016

@hansl @jelbourn I can tell you about few

  • no styles for invalid inputs
  • there's an issue with using [value] instead of [ngModel], but that could be related to binding inputs with [value] + ngControl angular#7690
  • no textareas
  • no bottom margin, this is way too stacked on each other
    image
  • while I like that there's just one component, unlike ng1 which had wrapper <md-input-container>, it makes it less friendly for customisation, since you can't easily utilise the md-is-active css class

@jelbourn
Copy link
Member Author

jelbourn commented Apr 7, 2016

@fxck

  • Invalid styles and textareas will be coming
  • The lack of margins is an intentional, library-wide design decision. It should be up to the user of the components to set margins, not the authors.
  • I'm not sure what you're referring to with md-is-active; I don't see a reference to this anywhere in the material1 source. Do you have some customization use-case in mind?

@fxck
Copy link
Contributor

fxck commented Apr 7, 2016

The lack of margins is an intentional, library-wide design decision. It should be up to the user of the components to set margins, not the authors.

Good to know, thanks! Although material1 used that free space to show errors, which seems reasonable.

I'm not sure what you're referring to with md-is-active; I don't see a reference to this anywhere in the material1 source. Do you have some customization use-case in mind?

Yea, sorry, I meant md-input-focused, basically I want this...

image

image

...which means my own "pseudo-label", and I want it to be blue when the input is focused, I haven't used material1 for ages, but think this was possible

<md-input-container>
  <h2 class="my-special-label">Whatever</h2>    
  <input ng-model="foo.bar">
</md-input-container>
.md-input-focused .my-special-label {
  color: whatever;
}

@jelbourn
Copy link
Member Author

jelbourn commented Apr 7, 2016

@fxck we could potentially add an isFocused property to the input. That would enable:

<md-input #nickname [class.pajama-party]="nickname.isFocused">

@fxck
Copy link
Contributor

fxck commented Apr 7, 2016

Yeah that's what I was thinking as well. That would sort of fixed the problem.

@hansl
Copy link
Contributor

hansl commented Apr 7, 2016

There is already, it’s called focused.

-- 
Hans Larsen
Sent with Airmail

On April 7, 2016 at 10:29:49 AM, Aleš ([email protected]) wrote:

Yeah that's what I was thinking as well. That would solve the problem.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@fxck
Copy link
Contributor

fxck commented Apr 14, 2016

Hello there @jelbourn @hansl, are those textareas and error styles going to be part of alpha.3? Since that new issue for missing parts doesn't really exist yet, it's hard to guess. Thanks!

@jelbourn
Copy link
Member Author

@fxck we haven't scheduled those features yet- the team is gearing up for ng-conf, so it will be some time after that.

@fxck
Copy link
Contributor

fxck commented May 10, 2016

I know I'm annoying, but is there ETA for textareas yet? I wonder by what method you decide which components have bigger priority than other, because to me, it would make sense to start with the basics, to which textarea arguably belongs, and then follow up with more fancy stuff, like md-bottom-nav..

@jelbourn
Copy link
Member Author

@fxck No ETA yet; one of our 20% contributors will probably take this on after they're finished with their current stuff.

@AhsanAyaz
Copy link

+1 for the text area

@CoreyGrant
Copy link

CoreyGrant commented Oct 11, 2016

Are there any plans on validation? And by that I mean error styles, and potentially even messages tied into reactive forms.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix new component This issue is tracking a new component to be added to the library
Projects
None yet
Development

No branches or pull requests

6 participants