Skip to content

feat(material/stepper): add the ability to control the position of the header in a horizontal stepper #15509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

crisbeto
Copy link
Member

Allows users to control where the header of a horizontal stepper is rendered. In some cases it might make more sense to have the buttons be under the content so that the user doesn't have to go back in the page layout in order to continue to the next step.

example

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Mar 17, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 17, 2019
@crisbeto crisbeto force-pushed the stepper-header-position branch from 7072b62 to 845f33d Compare March 17, 2019 10:47
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 1, 2019
@ngbot
Copy link

ngbot bot commented Apr 1, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@akvaliya
Copy link

What is the status of this feature?

@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@crisbeto crisbeto force-pushed the stepper-header-position branch from 845f33d to 402c3b0 Compare May 21, 2019 20:21
@crisbeto crisbeto force-pushed the stepper-header-position branch from 402c3b0 to 4a7643b Compare May 28, 2019 22:05
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jun 30, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 30, 2019
@angular angular deleted a comment from googlebot Jun 30, 2019
@crisbeto crisbeto force-pushed the stepper-header-position branch from 4a7643b to 6a25022 Compare June 30, 2019 09:13
@crisbeto crisbeto force-pushed the stepper-header-position branch 2 times, most recently from 6ba6bec to 28b5005 Compare August 6, 2019 13:40
@crisbeto crisbeto force-pushed the stepper-header-position branch from 28b5005 to 854907d Compare February 1, 2020 16:18
@crisbeto crisbeto force-pushed the stepper-header-position branch from 854907d to 484f331 Compare March 29, 2020 19:33
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@crisbeto crisbeto force-pushed the stepper-header-position branch from 484f331 to d1b0d2a Compare August 22, 2020 14:30
@crisbeto crisbeto requested a review from andrewseguin as a code owner August 22, 2020 14:30
@crisbeto crisbeto force-pushed the stepper-header-position branch from d1b0d2a to dc52652 Compare December 20, 2020 15:47
@crisbeto crisbeto changed the title feat(stepper): add the ability to control the position of the header in a horizontal stepper feat(material/stepper): add the ability to control the position of the header in a horizontal stepper Dec 20, 2020
@andrewseguin andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 29, 2021
…e header in a horizontal stepper

Allows users to control where the header of a horizontal stepper is rendered. In some
cases it might make more sense to have the buttons be under the content so that the
user doesn't have to go back in the page layout in order to continue to the next step.
@crisbeto crisbeto force-pushed the stepper-header-position branch from dc52652 to 4d2a3c0 Compare March 11, 2022 07:40
@crisbeto crisbeto requested a review from a team as a code owner March 11, 2022 07:40
@crisbeto crisbeto merged commit fc5f8b0 into angular:master Mar 14, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
…e header in a horizontal stepper (angular#15509)

Allows users to control where the header of a horizontal stepper is rendered. In some
cases it might make more sense to have the buttons be under the content so that the
user doesn't have to go back in the page layout in order to continue to the next step.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants