Skip to content

chore: add yarn logs to gitignore #13884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2018
Merged

chore: add yarn logs to gitignore #13884

merged 1 commit into from
Oct 30, 2018

Conversation

crisbeto
Copy link
Member

Adds the yarn-related logs to a gitignore so people don't try to commit them accidentally. See #13814.

@crisbeto
chore: add yarn logs to gitignore
ea9eaa4 
Adds the yarn-related logs to a gitignore so people don't try to commit them accidentally. See angular#13814.
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 30, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner October 30, 2018 18:37
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2018
josephperrott
josephperrott approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 30, 2018
jelbourn
jelbourn approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 7cfa0c5 into angular:master Oct 30, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@crisbeto @atscott
chore: add yarn logs to gitignore (angular#13884)
57479f5 
Adds the yarn-related logs to a gitignore so people don't try to commit them accidentally. See angular#13814.
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
@crisbeto @jelbourn
chore: add yarn logs to gitignore (#13884)
06b01a3 
Adds the yarn-related logs to a gitignore so people don't try to commit them accidentally. See #13814.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @josephperrott @googlebot