Skip to content

Conversation

devversion
Copy link
Member

@devversion devversion commented Oct 5, 2018

* By default TypeScript truncates the types when calling `typeToString`. Since we don't want to truncate the types automatically, we need to work around: angular/dgeni-packages#276 until there is a possibility to change this using the `tsHost`.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 5, 2018
@devversion devversion requested a review from jelbourn as a code owner October 5, 2018 21:23
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 5, 2018
@vivian-hu-zz vivian-hu-zz merged commit 4b15b78 into angular:master Oct 5, 2018
@devversion devversion deleted the build/docs-const-types-truncated branch October 6, 2018 15:19
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
* By default TypeScript truncates the types when calling `typeToString`. Since we don't want to truncate the types automatically, we need to work around: angular/dgeni-packages#276 until there is a possibility to change this using the `tsHost`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants