fix(list): selection list not marking options as selected correctly when setting value with duplicates #13363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
pr: lgtm
action: merge
…hen setting value with duplicates Along the same lines as angular#13361. Fixes the selection list not marking all selected options correctly when an array with duplicate values is assigned programmatically.
crisbeto
force-pushed
the
selection-list-duplicate-values
branch
from
776f885 to
411554d
Compare
jelbourn
reviewed
Oct 2, 2018
| listOptions = fixture.debugElement.queryAll(By.directive(MatListOption)) | ||
| .map(optionDebugEl => optionDebugEl.componentInstance); | ||
|
|
||
| fixture.componentInstance.selectedOptions = ['one', 'two', 'two']; |
There was a problem hiding this comment.
What would this look like if I wanted to select only the second "two" value?
There was a problem hiding this comment.
That wouldn't be possible, it'll always hit the first one.
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
…hen setting value with duplicates (angular#13363) Along the same lines as angular#13361. Fixes the selection list not marking all selected options correctly when an array with duplicate values is assigned programmatically.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the same lines as #13361. Fixes the selection list not marking all selected options correctly when an array with duplicate values is assigned programmatically.