fix(select): not marking options as selected correctly when setting value with duplicates #13361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 29, 2018
…hen setting value with duplicates Along the same lines as angular#13361. Fixes the selection list not marking all selected options correctly when an array with duplicate values is assigned programmatically.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 29, 2018
…hen setting value with duplicates Along the same lines as angular#13361. Fixes the selection list not marking all selected options correctly when an array with duplicate values is assigned programmatically.
jelbourn
approved these changes
Oct 2, 2018
src/lib/select/select.spec.ts
Outdated
| { value: 'pizza-1', viewValue: 'Pizza' }, | ||
| { value: 'pizza-1', viewValue: 'Pizza' }, | ||
| { value: 'pizza-1', viewValue: 'Pizza' }, | ||
| { value: 'pizza-1', viewValue: 'Pizza' }, |
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
…hen setting value with duplicates (angular#13363) Along the same lines as angular#13361. Fixes the selection list not marking all selected options correctly when an array with duplicate values is assigned programmatically.
crisbeto
force-pushed
the
13179/select-programmatic-duplicate-values
branch
from
9bb294d to
8b08a59
Compare
andrewseguin
added
the
P3
crisbeto
force-pushed
the
13179/select-programmatic-duplicate-values
branch
from
8b08a59 to
47751b4
Compare
…alue with duplicates Fixes `mat-select` not marking all of the options as selected, when an array with duplicate values is assigned programmatically. Fixes angular#13179.
crisbeto
force-pushed
the
13179/select-programmatic-duplicate-values
branch
from
47751b4 to
d95d10d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
mat-selectnot marking all of the options as selected, when an array with duplicate values is assigned programmatically.Fixes #13179.