Skip to content

chore: add example for ripple #12063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2018

Conversation

devversion
Copy link
Member

  • Moves the ripple demo into a more bare-bone example that can shown in the docs at some point.

References #7543

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 4, 2018
* Moves the ripple demo into a more bare-bone example that can shown in the docs at some point.

References angular#7543
@devversion devversion force-pushed the chore/add-example-for-ripple branch from 4381a96 to 64cd49c Compare July 9, 2018 18:03
margin: 6px 12px 6px 0;
}

mat-form-field {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use css classes for these styles instead of styling the elements directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I didn't intend to use a class here because I felt like it would bloat the example HTML and since we have view encapsulation turned on for the examples, it wouldn't affect other things.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I insist on because it makes it easier for people inspecting the demos to know the difference between the component styles and the example styles.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 10, 2018
@jelbourn jelbourn merged commit dd7421d into angular:master Jul 11, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants