Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 5, 2018

Fixes the tooltip reopening immediately when clicking on the trigger, due to it receiving mouse/touch focus. These changes restrict it to only be able to open via keyboard focus.

Fixes #10709.

Fixes the tooltip reopening immediately when clicking on the trigger, due to it receiving mouse/touch focus. These changes restrict it to only be able to open via keyboard focus.

Fixes angular#10709.
@crisbeto crisbeto requested a review from andrewseguin as a code owner April 5, 2018 20:22
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 5, 2018
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 29, 2018
@ngbot
Copy link

ngbot bot commented May 29, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott josephperrott merged commit 74f4364 into angular:master May 30, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[6.0.0-rc.0] mat-tooltip on mat-button flickering on click
5 participants