-
Notifications
You must be signed in to change notification settings - Fork 6.8k
bug(expansion): toggle icon not being updated #5623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Jul 10, 2017
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow. Fixes angular#5623.
Picking this one up as per chat with @devversion. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Jul 25, 2017
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow. Fixes angular#5623.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Jul 26, 2017
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow. Fixes angular#5623.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Jul 27, 2017
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow. Fixes angular#5623.
andrewseguin
pushed a commit
that referenced
this issue
Jul 28, 2017
…lly (#5650) * fix(expansion-panel): toggle not being updated when set programmatically Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from #5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow. Fixes #5623. * chore: add a couple of unit tests for the fixes
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
Bug, feature request, or proposal:
bug
What is the expected behavior?
If you switch the
expanded
input from false-true-false... the toggle icon on the upper right corner should change it's direction.What is the current behavior?
It's not changing, unless you click on the expansion header
What are the steps to reproduce?
At the plunker, click on the
toggle panel
button bellow the expansion to switch its state and watch the not-changing toggle icon.Plunker: https://plnkr.co/edit/SIkVCu?p=preview
What is the use-case or motivation for changing an existing behavior?
Programmatically open and close the expansion
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Material latest builds
Is there anything else we should know?
expanded == true
expanded == false
The text was updated successfully, but these errors were encountered: