bug(selection-model): setSelection in SelectionModel does not respect compareWith

[iladovi]

Is this a regression?

• Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

When using compareWith, setSelection method may deselect comparable items.
Cause is usage of Set and has method

components/src/cdk/collections/selection-model.ts

Lines 94 to 98 in 7c8a796

	const newSelectedSet = new Set(values);
	values.forEach(value => this._markSelected(value));
	oldValues
	.filter(value => !newSelectedSet.has(value))
	.forEach(value => this._unmarkSelected(value));

This line

components/src/cdk/collections/selection-model.ts

Line 94 in 7c8a796

const newSelectedSet = new Set(values);

could be replaced by
const newSelectedSet = new Set(values.map(value => this._getConcreteValue(value)));
to use compareWith

Reproduction

StackBlitz link: https://stackblitz.com/edit/angular-jfhnli?file=src%2Fmain.ts
Steps to reproduce:

1. Instanciate a SelectionModel of object and non trivial compareWith function
2. call setSelection method to select one object o1, selectionModel.selection should be [o1]
3. call setSelection again with a copy o2 of previous object (o2 must be comparable to o1 according compareWith, ie compareWith(o1,o2) is true)

Expected Behavior

SelectionModel selection should be one of the selected objects, either [o1] or [o2]

Actual Behavior

SelectionModel selection is empty

Environment

• Angular: 16
• CDK/Material: 16
• Browser(s): no browser needed
• Operating System (e.g. Windows, macOS, Ubuntu): Windows

[zarend]

Hello @iladovi,

Thank you for reaching this and proving a Stackblitz reproduction. Are you interested in contributing?

If so, we welcome you to create a PR to fix this. Seems like you have already gotten part of the way towards solving this.

Let us know if you want to take this on. The first step is to read the instructions in Contributing to Angular Material
. One your development environment is setup, I suggest making a failing unit test for this case.

-Zach

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}