Skip to content

Disable screenshot capture and delete existing screenshots #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RichOren opened this issue Mar 25, 2016 · 6 comments
Closed

Disable screenshot capture and delete existing screenshots #228

RichOren opened this issue Mar 25, 2016 · 6 comments
Assignees
@robertmesserle
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone
alpha.2

Comments

@RichOren
Copy link
Contributor

When I fork this repo it is detecting changes to the PNG files and wanting me to commit those files and then it just keeps adding them to my staged list. Do these really need to be version controlled? Can they be ignored?
@devversion
Copy link
Member

@RichOren I have the same problem. Removing / discarding them isn't working, seems like Git LFS always recreates them.

@RichOren
Copy link
Contributor Author

@devversion - Confirmed that is what is happening to me also.

@jelbourn jelbourn added this to the alpha.2 milestone Mar 25, 2016
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Mar 25, 2016
@jelbourn
Copy link
Member

@robertmesserle we should remove the screenshot running from the repo for now, since we're not really getting any value from it.

@jelbourn jelbourn changed the title Do we need the screenshot folder in source control? Disable screenshot capture and delete existing screenshots Mar 25, 2016
@robertmesserle
Copy link
Contributor

@jelbourn Agreed, I'll submit a PR.

@robertmesserle robertmesserle mentioned this issue Mar 25, 2016
Closed
@devversion
Copy link
Member

Meanwhile, #232 is pending, I deleted all contents of .git/lfs/, otherwise I'm not able to switch branches.

andrewseguin pushed a commit to andrewseguin/components that referenced this issue Oct 15, 2018
@amcdnl @jelbourn
fix(stackblitz): fix dialogs not working angular#5899 angular#228 ang…
9c78345 
…ular#8750 (angular#356)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@robertmesserle robertmesserle

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
alpha.2
Development

Successfully merging a pull request may close this issue.

fix(e2e): removes screenshot directory and code to generate screenshots
4 participants
@robertmesserle @jelbourn @RichOren @devversion