Skip to content

fix(storage): Add our zone wrappers for download url and meta-data #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

jamesdaniels
Copy link
Member

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

@jamesdaniels jamesdaniels self-assigned this Apr 5, 2018
@jamesdaniels jamesdaniels requested a review from davideast April 5, 2018 19:55
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @jamesdaniels! Thanks for getting this fix in on the go.

@@ -18,12 +19,20 @@ export interface AngularFireStorageReference {
* creates observable methods from promise based methods.
* @param ref
*/
export function createStorageRef(ref: Reference): AngularFireStorageReference {
export function createStorageRef(ref: Reference, scheduler: FirebaseZoneScheduler): AngularFireStorageReference {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad, but necessary. 😢

@jamesdaniels jamesdaniels merged commit 99a2a81 into angular:master Apr 5, 2018
@jamesdaniels jamesdaniels deleted the storage_zone_work branch April 5, 2018 20:56
myspivey pushed a commit to myspivey/angularfire2 that referenced this pull request Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants