Crash with ng6 AOT compilation

[Ploppy3]

Version info

Angular:
6
Firebase:
4.12.1
AngularFire:
5.0.0-rc.7
Other (e.g. Ionic/Cordova, Node, browser, operating system):

How to reproduce these conditions

Failing test unit, Plunkr, or JSFiddle demonstrating the problem

Steps to set up and reproduce
https://github.com/vincent-cm/angular-starter-test

Sample data and security rules

<-- include/attach/link to some json sample data (or provide credentials to a sanitized, test Firebase project) -->

Debug output

** Errors in the JavaScript console **

Uncaught (in promise): TypeError: Cannot read property 'OVERWRITE' of undefined
TypeError: Cannot read property 'OVERWRITE' of undefined

** Output from firebase.database().enableLogging(true); **

** Screenshots **

Expected behavior

Actual behavior

[byrondover]

This appears to be a side effect of @angular-devkit/build-optimizer optimizations.

[jamesdaniels]

We're supporting Angular 6 now, can you confirm if this is still an issue in angularfire2@next

[jamesdaniels]

Going to close unless confirmed issue with our latest release

[Ploppy3]

@jamesdaniels Updating comes with a bunch of new errors, so I can't even test.

Incompatibilities with rxjs which I managed to fix.

One still persist:

Cannot read property 'GoogleAuthProvider' of undefined

import { AngularFireAuth } from 'angularfire2/auth';
import * as firebase from 'firebase/app';

@Component({
  ...
})

export class WelcomeComponent {

  constructor(
    public afAuth: AngularFireAuth,
  ) { }

  public signIn() {
    this.afAuth.auth.signInWithRedirect(new firebase.auth.GoogleAuthProvider());
  }

}

"angularfire2": "^5.0.0-rc.8",
"firebase": "5.0.2",

Seems pretty similar to the official doc: https://github.com/angular/angularfire2/blob/master/docs/auth/getting-started.md

[Ploppy3]

@jamesdaniels
Changing from
import * as firebase from 'firebase';
to
import { firebase } from '@firebase/app';
Fixed this issue.

Please change the docs accordingly: https://github.com/angular/angularfire2/blob/master/docs/auth/getting-started.md

[Ploppy3]

@jamesdaniels So it's even more broken now. It won't even start to compile:

ERROR in Error during template compile of 'AppModule'
Function calls are not supported in decorators but 'AngularFireModule' was called.

So please, reopen.

[jamesdaniels]

@Ploppy3 I saw an error about that on the angular repo, that sounds like an issue with your tsconf. Have you tried the provides syntax for configuring rather than using initializeApp instead?

  ...
  imports: [
    AngularFireModule,
    ...
  ],
  providers: [
    { provide: FirebaseOptionsToken,   useValue: YOUR_OPTIONS },
    { provide: FirebaseAppNameToken,   useValue: undefined },
    { provide: FirebaseAppConfigToken, useValue: undefined },
  ],

[Ploppy3]

@jamesdaniels Nailed it, it works, and build properly now.

Are those providers subject to change anytime soon? Is it OK to stay in this situation or should I find what's going wrong?

Also, all of this somehow fixed my karma tests which would not run. Thank you!

[jamesdaniels]

These providers are stable, I'm not sure what the root cause is. initializeApp() just sets these for you.