fix(templateRequest): allow empty html template #9713
Conversation
|
ngEurope sprint with Vojta pull request. |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
cmichal
force-pushed
the
emptyTemplate-fix
branch
2 times, most recently
from
466b09e to
50b6481
Compare
| @@ -49,7 +49,7 @@ function $TemplateRequestProvider() { | |||
| return $http.get(tpl, httpOptions) | |||
| .then(function(response) { | |||
| var html = response.data; | |||
| if (!html || html.length === 0) { | |||
| if (!html && html !== '') { | |||
There was a problem hiding this comment.
Shouldn't we instead use the status code (or $http(...).success().error())?
What happens if the request returns 404?
I think with this change, it will just act as if the template was empty.
There was a problem hiding this comment.
Actually, that is already happening (I didn't see line 59).
So can't you just remove this condition?
allow empty html template and not throw error Closes angular#9581
cmichal
force-pushed
the
emptyTemplate-fix
branch
from
50b6481 to
9bc1f1b
Compare
allow empty html template and not throw error
Closes #9581