Skip to content

added support for a new sass-files option #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

randyaa
Copy link

@randyaa randyaa commented May 20, 2016

Projects that have a large number of sass files but only a few that need to be compiled because of @imports can have a hard time with the CLI because of the automatic compilation included in the current implementation of the sass plugin.

This pull request adds the capability to provide a list of 'sass-files' that restrict the compiler to only compile files that end with the given name(s) or extensions. ends-with was the chosen solution so we can support the default configuration of compiling everything that ends with .scss or .sass

In use this looks like:

  return new Angular2App(defaults, {
    vendorNpmFiles: [],
    sassCompiler:{
      "sass-files":["main.scss"]
    }
  });

addresses Issue 831

When `sass-files` is set to an array of strings the compiler will only compile files that end with the given name(s) or extensions.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@randyaa
Copy link
Author

randyaa commented May 20, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@randyaa
Copy link
Author

randyaa commented May 20, 2016

This is already handled by way of the cacheExclude parameter.

as an example, using this configuration in the Angular2App options will skip any files prefixed with a _

    sassCompiler:{
        "cacheExclude": [/\/_[^\/]+$/]
    }

@randyaa randyaa closed this May 20, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants