test: Add missing peer dependency #7385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ngtools/webpack requires a peer dependency of enhanced-resolve@^3.1.0. It currently relies on webpack providing this dependency and on NPM 3+ flat tree installation. Webpack could remove this dependency or NPM change the tree structure. This change also removes a NPM warning about missing peer dependency.
|
Heya, I don't think webpack will move So yeah, the better solution for us right now is to add it ourselves. It's better to move it from a peer dependency in |
This reverts commit 891c3de.
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
…o dependencies (angular#7385) @ngtools/webpack requires a peer dependency of enhanced-resolve@^3.1.0. It currently relies on webpack providing this dependency and on NPM 3+ flat tree installation. Webpack could remove this dependency or NPM change the tree structure. This change also removes a NPM warning about missing peer dependency.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ngtools/webpackrequires a peer dependency ofenhanced-resolve@^3.1.0. It currently relies onwebpackproviding this dependency and onNPM 3+flat tree installation.Webpackcould remove this dependency orNPMchange the tree structure. This change also removes a NPM warning about missing peer dependency.