Skip to content

feat(@angular/cli): bump blueprint dependencies #6811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

danielsogl
Copy link
Contributor

No description provided.

@danielsogl danielsogl changed the title chore(blueprint): bump dependencies build(blueprint): bump dependencies Jun 26, 2017
@danielsogl danielsogl changed the title build(blueprint): bump dependencies build(@angular/cli): bump blueprint dependencies Jun 26, 2017
@hansl
Copy link
Contributor

hansl commented Jun 26, 2017

@filipesilva This is a feature and will have to wait for 1.3.

@danielsogl danielsogl changed the title build(@angular/cli): bump blueprint dependencies feat(@angular/cli): bump blueprint dependencies Jun 26, 2017
@danielsogl
Copy link
Contributor Author

@hansl thank you for pointing me out! I changed the PR title.

@clydin
Copy link
Member

clydin commented Jun 26, 2017

Note also that the current versioning will install the latest versions (within the current major).

"codelyzer": "~3.0.1",
"@angular/compiler-cli": "^4.2.4",
"@angular/language-service": "^4.2.4",<% if (!minimal) { %>
"@types/jasmine": "2.5.53",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jasmine types can't be updated in isolation. See PR #6799 for details.

"@angular/compiler-cli": "^4.2.4",
"@angular/language-service": "^4.2.4",<% if (!minimal) { %>
"@types/jasmine": "2.5.53",
"@types/node": "~8.0.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should track node v6 to support the minimum version required by the CLI.

"@types/jasmine": "2.5.45",
"@angular/compiler-cli": "^4.2.4",
"@angular/language-service": "^4.2.4",<% if (!minimal) { %>
"@types/jasmine": "2.5.53",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break e2e tests compilation, unless #6799 is merged

@filipesilva
Copy link
Contributor

Heya, you'll have to rebase on top of master since #6799 was merged just now. You also have to rebase to a single commit since in order to pass the commit message check.

@filipesilva filipesilva assigned filipesilva and unassigned hansl Jun 27, 2017
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the note above 👍

@danielsogl
Copy link
Contributor Author

danielsogl commented Jun 27, 2017

I have some problems with my local git setup so I created a new PR.

#6817

@danielsogl danielsogl closed this Jun 27, 2017
@danielsogl danielsogl deleted the patch-1 branch June 30, 2017 08:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants