chore(@angular/cli): bump jasmine and add jasminewd2 types #6799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps jasmine types to 2.5.53. The version was previously pinned down to 2.5.45, because more recent versions weren't playing nice with Protractor and lead to errors like angular/protractor#4176 The proper fix appears to be the one mentioned in the Protractor issue: add `@types/jasminewd2` typings, and add these typings to the tsconfig for e2e tests. [jasminewd](https://github.com/angular/jasminewd) is the adapter used by Protractor to handle the async part.
cexbrayat
force-pushed
the
fix/jasmine-types
branch
from
eb6daba to
930b717
Compare
filipesilva
approved these changes
Jun 27, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps jasmine types to 2.5.53.
The version was previously pinned down to 2.5.45, because more recent versions weren't playing nice with Protractor
and lead to errors like angular/protractor#4176
The proper fix appears to be the one mentioned in the Protractor issue: add
@types/jasminewd2typings, and add these typings to the tsconfig for e2e tests.jasminewd is the adapter used by Protractor to handle the async part.