Skip to content

feat(@angular/cli): inline style and templates in defaults #6571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

feat(@angular/cli): inline style and templates in defaults #6571

wants to merge 4 commits into from

Conversation

gioragutt
Copy link
Contributor

  • inlineStyle and inlineTemplate are now generated in .angular-cli.json.
  • default stays false for both, but if ng new [name] is specified with -is or -it, those will be stored as true in .angular-cli.json respectively
  • added unit tests and e2e test

fixes #6570

@gioragutt gioragutt force-pushed the inline-template-and-inline-style-in-config branch 3 times, most recently from c93151b to 478184e Compare June 3, 2017 22:25
@gioragutt
Copy link
Contributor Author

@hansl look at this travis log, can the build be broken on master?

@gioragutt gioragutt force-pushed the inline-template-and-inline-style-in-config branch 2 times, most recently from d822afa to 5741bd7 Compare June 4, 2017 00:25
@sumitarora sumitarora requested a review from hansl June 6, 2017 13:32
@filipesilva filipesilva requested a review from sumitarora June 6, 2017 14:07
sumitarora
sumitarora suggested changes Jun 6, 2017
View reviewed changes
Copy link
Contributor

@sumitarora sumitarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs as well new.md

@gioragutt
Copy link
Contributor Author

@sumitarora will do. Currently in France and my laptop charger won't fit the plugs, is it possible to update the branch from the mobile website?

@gioragutt gioragutt force-pushed the inline-template-and-inline-style-in-config branch from 5741bd7 to 7d8b7f7 Compare June 7, 2017 19:58
@gioragutt
Copy link
Contributor Author

@sumitarora I've updated the docs. Notice that I have another PR, #6480, where I update the new command docs. If this is merged before the other PR, I'll revise the other PR and adjust the docs based on the changes I've made in the PR.

Also notice #6570, @Brocco made a suggestion regarding this PR, I believe It should be taken into consideration.

@gioragutt gioragutt mentioned this pull request Jun 10, 2017
Closed
gioragutt added 3 commits June 12, 2017 17:11
@gioragutt
feat(@angular/cli): inline style and templates in defaults
7011355 
* `inlineStyle` and `inlineTemplate` are now generated in `.angular-cli.json`.
* default stays `false` for both, but if `ng new [name]` is specified with `-is` or `-it`, those will be stored as `true` in `.angular-cli.json` respectively
* added unit tests and e2e test
@gioragutt
fix(@angular/cli): change component blueprint to pass tests when usin…
2aa5040 
…g --inline-template

* note: this error already came up in angular#6538, so I'm just fixing the title so that the PR would not cause any merge-conflicts
@gioragutt
docs(@angular/cli): add docs regarding default inline template and st…
5a3b046 
…yles
@gioragutt gioragutt force-pushed the inline-template-and-inline-style-in-config branch from 7d8b7f7 to 4688054 Compare June 12, 2017 19:46
@gioragutt
Copy link
Contributor Author

@sumitarora @Brocco i've updated the PR according to @Brocco 's suggestion in #6570 regarding --inline-style-all and --inline-template-all. Would love to get a review on that

@gioragutt
feat(@angular/cli): add inline-template-all and inline-style-all
a8cba1c 
* instead of `-is` and `-it` setting the defaults, alternative `-all` flag were added to instead set the defaults, whereas it is decided that the existing will stay unchanged and will only affect `AppComponent`
* added respective unit tests and e2e test
* added respective docs
* general styling fixes (vscode format document)
@gioragutt gioragutt force-pushed the inline-template-and-inline-style-in-config branch from 4688054 to a8cba1c Compare June 12, 2017 21:25
@gioragutt
Copy link
Contributor Author

@Brocco can I get a review on this?

@gioragutt
Copy link
Contributor Author

@Brocco @sumitarora @filipesilva this is idle for quite some time, could you guys review this so this gets merged?

@filipesilva filipesilva assigned Brocco and unassigned sumitarora Jun 28, 2017
@filipesilva
Copy link
Contributor

@Brocco can you have a look?

@hansl
Copy link
Contributor

hansl commented Sep 27, 2017

Closing every Blueprints related issue and PR.

@hansl hansl closed this Sep 27, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hansl hansl Awaiting requested review from hansl

1 more reviewer

@sumitarora sumitarora sumitarora requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have ng g c [name] generate inline-template and inline-style automatically from config
6 participants
@gioragutt @filipesilva @hansl @sumitarora @Brocco @googlebot