Skip to content

feat(@angular/cli): adds --animation flag to ng new #6244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dave11mj
Copy link
Contributor

@dave11mj dave11mj commented May 9, 2017

Fixes #6243

@dave11mj dave11mj force-pushed the feat-ng-new-animation-flag branch 2 times, most recently from 5e345b9 to 98135cd Compare May 9, 2017 21:16
@filipesilva filipesilva requested a review from Brocco May 10, 2017 10:25
@filipesilva
Copy link
Contributor

@Brocco can you review is this is functionality we want, since you were more involved in #6144?

@intellix
Copy link
Contributor

Any reason why you're not using NoopAnimationsModule within app.module.spec.ts?

@dave11mj dave11mj closed this May 10, 2017
@dave11mj dave11mj reopened this May 10, 2017
@dave11mj dave11mj force-pushed the feat-ng-new-animation-flag branch from 98135cd to a0dde2b Compare May 10, 2017 14:38
@dave11mj
Copy link
Contributor Author

@intellix the main reason is because because I didn't know the difference between the two. Although, after a quick search I completely agree NoopAnimationsModule (No Operation meant for testing) should be used in app.component.spec.ts (I couldn't find the file you mentioned) instead of BrowserAnimationsModule. I tested it and updated the commit. Thanks for the feedback ! :D

PS: Sorry about closing the PR while trying to comment xD..

@dave11mj
Copy link
Contributor Author

dave11mj commented May 10, 2017

@Brocco to pick up from your feedback on #5786 I included both BrowserAnimationsModule and BrowserModule since that's how is officially documented and when including only BrowserAnimationsModule causes the error below. ^^

image

@hansl
Copy link
Contributor

hansl commented Sep 27, 2017

Closing every Blueprints related issue and PR.

@hansl hansl closed this Sep 27, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BrowserAnimationsModule optional support to new applications
6 participants