-
Notifications
You must be signed in to change notification settings - Fork 12k
Add BrowserAnimationsModule optional support to new applications #6243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BrowserAnimationsModule optional support to new applications #6243
Comments
@filipesilva @Brocco @dave11mj, would it be worth making this more generic? for example the cli generates a base project with only the bare minimum and then allows the user to pass in which optional modules they would like to include? something like ng new cool-project --modules=Router,Animations,Http |
We generally try to avoid adding library conditionals in |
I think it would make sense for all optional modules maintained in the core angular repo. |
@deebloo I like the idea of a more generic @filipesilva I would not consider animations just another library / small module. It's being part of the angular core for a long time and one really appealing feature. It also has other libraries that depend on it like Angular Material. That's why I feel could be treating like Another reason I feel an |
With the advent of |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug Report or Feature Request (mark with an
x
)Versions.
Repro steps.
ng new test-animation
app.component.ts
and replace its content with the snipped belowapp.component.html
and use the@testFadeIn
triggerng serve
and open the developer tools.The log given by the failure.
Desired functionality.
To be able to create new applications that support animations without additional configurations. This would make it easier to use transitions and Angular Material.
An option I would propose is a
--animation
flag to theng new
command which would allow users to opt-in on supporting animations for their applications.Mention any other details that might be useful.
Animations is one of the features I really like about angular, and can be sometimes tricky to set up. ^^
The text was updated successfully, but these errors were encountered: