Skip to content

docs: improve the github issue template for the repo #5350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2017

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Mar 9, 2017

No description provided.

@Brocco Brocco force-pushed the issue-template branch 3 times, most recently from f05fa34 to d2b1688 Compare March 9, 2017 19:57
- [ ] bug report -> please search issues before submitting
- [ ] feature request

<!-- if bug report, otherwise delete -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you should add an additional empty line before this one, check the preview: https://github.com/Brocco/angular-cli/blob/aaa899e2de344f9d6000deac5593cd3c7f15dca2/.github/ISSUE_TEMPLATE.md

> Please run `ng --version`. If there's nothing outputted, please run in a Terminal: `node --version` and paste the result here:
<!--
Output from: `ng --version`.
If nothing, output from: `node --version` and include OS details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also npm --version along with node version.

### Repro steps.
> Was this an app that wasn't created using the CLI? What change did you do on your code? etc.
<!-- Steps to reproduce this bug. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace this with:

<!-- 
Simple steps to reproduce this bug. 
If the issue can be seen with little or no code changes in a brand new project, list the list of commands to reproduce it.
Otherwise, in cases where a fair amount of code needs to be added, please make a new GitHub repo starting with a fresh CLI project to show the issue.
If we can't follow these steps to reproduce the bug, your issue will be closed as non-reproducible.
-->

I ask because I have to write this over and over again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree, the point of this exercise is to make the template less intimidating hopefully getting more people to use the template to help us out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I agree that the blurb I asked for is actually fairly intimidating and that's counterproductive.

But I would still like to see some elaboration of what's the kind of repro we're looking for. A lot (and I do mean a lot) of users just put in something like "When I run ng serve I get this error".

And that fits the bill of a simple repro... which is to run ng serve. But for us it's useless. It just results in a issue I mark as 'needs repro' and never have a lot of time to come back to.



<!-- if bug report, otherwise delete -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these will have any effect for the target audience of these changes. I think They'll just leave them in. We can remove them later if that's the case.


<!-- if feature, otherwise delete -->
### Desired functionality.
<!-- What would like to see implemented? -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add What is the usecase?.

@Brocco Brocco merged commit 8530a82 into angular:master Mar 14, 2017
@Brocco Brocco deleted the issue-template branch March 14, 2017 15:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants