chore: add a first draft of the config schema. #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
force-pushed
the
config
branch
2 times, most recently
from
321a084 to
85d278e
Compare
| "apps": { | ||
| "description": "Properties of the different applications in this project.", | ||
| "type": "array", | ||
| "items": { |
There was a problem hiding this comment.
This items is missing the additionalProperties property. (Not sure if it was intentional, but it seems to be the only one.)
There was a problem hiding this comment.
It's not intentional for this one, but as it's true by default I'll add it since I don't want it to be extensible.
|
@hansl thanks! LGTM |
hansl
force-pushed
the
config
branch
3 times, most recently
from
0b9a331 to
8522e6b
Compare
|
👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.