Skip to content

Commit 095189b

Browse files
committed
Merge branch 'master' into config
2 parents 8522e6b + 555f184 commit 095189b

File tree

6 files changed

+43
-13
lines changed

6 files changed

+43
-13
lines changed

addon/ng2/blueprints/component/files/__path__/__name__.component.ts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,16 @@ import {RouteConfig, ROUTER_DIRECTIVES, ROUTER_PROVIDERS} from 'angular2/router'
33

44
@Component({
55
moduleId: __moduleName,
6-
selector: '<%= dasherizedModuleName %>',
7-
templateUrl: '<%= dasherizedModuleName %>.component.html',
8-
styleUrls: ['<%= dasherizedModuleName %>.component.<%= styleExt %>']<% if (route) { %>,
6+
selector: '<%= dasherizedModuleName %>',<% if(inlineTemplate) { %>
7+
template: `
8+
<p>
9+
<%= dasherizedModuleName %> Works!
10+
</p><% if (route) { %>
11+
<router-outlet></router-outlet><% } %>
12+
`,<% } else { %>
13+
templateUrl: '<%= dasherizedModuleName %>.component.html',<% } if(inlineStyle) { %>
14+
styles: []<% } else { %>
15+
styleUrls: ['<%= dasherizedModuleName %>.component.<%= styleExt %>']<% } if (route) { %>,
916
directives: [ROUTER_DIRECTIVES]<% } %>
1017
})<% if (route) { %>
1118
@RouteConfig([

addon/ng2/blueprints/component/index.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ module.exports = {
2020

2121
availableOptions: [
2222
{ name: 'flat', type: Boolean, default: false },
23-
{ name: 'route', type: Boolean, default: false }
23+
{ name: 'route', type: Boolean, default: false },
24+
{ name: 'inline-template', type: Boolean, default: false, aliases: ['it'] },
25+
{ name: 'inline-style', type: Boolean, default: false, aliases: ['is'] }
2426
],
2527

2628
normalizeEntityName: function (entityName) {
@@ -42,6 +44,8 @@ module.exports = {
4244
return {
4345
dynamicPath: this.dynamicPath.dir.replace(this.dynamicPath.appRoot, ''),
4446
flat: options.flat,
47+
inlineTemplate: options.inlineTemplate,
48+
inlineStyle: options.inlineStyle,
4549
route: options.route,
4650
styleExt: this.styleExt,
4751
isLazyRoute: !!options.isLazyRoute,
@@ -58,6 +62,12 @@ module.exports = {
5862
if (this.options && !this.options.route) {
5963
fileList = fileList.filter(p => p.indexOf(path.join('shared', 'index.ts')) <= 0);
6064
}
65+
if (this.options && this.options.inlineTemplate) {
66+
fileList = fileList.filter(p => p.indexOf('.html') < 0);
67+
}
68+
if (this.options && this.options.inlineStyle) {
69+
fileList = fileList.filter(p => p.indexOf('.__styleext__') < 0);
70+
}
6171

6272
return fileList;
6373
},

addon/ng2/blueprints/ng2/files/gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,5 @@ testem.log
2424
/e2e/*.js
2525
/e2e/*.map
2626

27+
#System Files
28+
.DS_Store

addon/ng2/blueprints/route/index.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,11 @@ module.exports = {
1313
availableOptions: [
1414
{ name: 'skip-router-generation', type: Boolean, default: false, aliases: ['srg'] },
1515
{ name: 'default', type: Boolean, default: false },
16-
{ name: 'lazy', type: Boolean, default: true }
16+
{ name: 'lazy', type: Boolean, default: true },
17+
{ name: 'inline-template', type: Boolean, default: false, aliases: ['it'] },
18+
{ name: 'inline-style', type: Boolean, default: false, aliases: ['is'] }
1719
],
18-
20+
1921
beforeInstall: function(options) {
2022
options.route = true;
2123
if (options.lazy) {
@@ -38,7 +40,7 @@ module.exports = {
3840
var parsedPath = dynamicPathParser(this.project, entityName);
3941

4042
this.dynamicPath = parsedPath;
41-
43+
4244
//leave the entity name intact for component generation
4345
return entityName;
4446
},
@@ -113,7 +115,7 @@ module.exports = {
113115

114116
// Insert the import statement.
115117
let content = fs.readFileSync(parentFile, 'utf-8');
116-
const importTemplate = `import {${jsComponentName}Component} from './+${base}';`;
118+
const importTemplate = `import {${jsComponentName}Component} from './${options.isLazyRoute ? '+' : ''}${base}';`;
117119

118120
if (content.indexOf(importTemplate) != -1) {
119121
// Already there, do nothing.

bin/ng

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ const resolve = require('resolve');
88
const exit = require('exit');
99
const packageJson = require('../package.json');
1010
const Leek = require('leek');
11-
const fs = require('fs');
1211

1312
resolve('angular-cli', { basedir: process.cwd() },
1413
function (error, projectLocalCli) {
@@ -29,10 +28,6 @@ resolve('angular-cli', { basedir: process.cwd() },
2928
cli = cli['default'];
3029
}
3130

32-
if ('default' in cli) {
33-
cli = cli['default'];
34-
}
35-
3631
cli({
3732
cliArgs: process.argv.slice(2),
3833
inputStream: process.stdin,

tests/acceptance/generate-component.spec.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,4 +159,18 @@ describe('Acceptance: ng generate component', function () {
159159
expect(existsSync(testPath)).to.equal(true);
160160
});
161161
});
162+
163+
it('ng generate component my-comp --inline-template', function () {
164+
return ng(['generate', 'component', 'my-comp', '--inline-template']).then(() => {
165+
var testPath = path.join(root, 'tmp', 'foo', 'src', 'client', 'app', 'my-comp', 'my-comp.component.html');
166+
expect(existsSync(testPath)).to.equal(false);
167+
});
168+
});
169+
170+
it('ng generate component my-comp --inline-style', function () {
171+
return ng(['generate', 'component', 'my-comp', '--inline-style']).then(() => {
172+
var testPath = path.join(root, 'tmp', 'foo', 'src', 'client', 'app', 'my-comp', 'my-comp.component.css');
173+
expect(existsSync(testPath)).to.equal(false);
174+
});
175+
});
162176
});

0 commit comments

Comments
 (0)