Skip to content

fix(tests): fix e2e workflow on appveyor #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2016
Merged

fix(tests): fix e2e workflow on appveyor #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/e2e/e2e_workflow.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe('Basic end-to-end Workflow', function () {

// Can't user the `ng` helper because somewhere the environment gets
// stuck to the first build done
sh.exec('./node_modules/.bin/ng build --environment=production --silent');
sh.exec(`node_modules${path.sep}.bin${path.sep}ng build --environment=production --silent`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using that path, shouldn't sh.exec('ng build --silent'); be okay?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might not have ng installed globally, or not linked in your PATH.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is the reason. Now that you mention it, since the e2e tests run npm link, a simple ng build should work as well.

I'll make another PR to simply this.

expect(existsSync(path.join(process.cwd(), 'dist'))).to.be.equal(true);
var envPath = path.join(process.cwd(), 'dist', 'app', 'environment.js');
var envContent = fs.readFileSync(envPath, { encoding: 'utf8' });
Expand Down