fix(tests): fix e2e workflow on appveyor #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
fix-e2e-windows
branch
from
e36cd6b to
39c70e6
Compare
| @@ -62,7 +62,7 @@ describe('Basic end-to-end Workflow', function () { | |||
|
|
|||
| // Can't user the `ng` helper because somewhere the environment gets | |||
| // stuck to the first build done | |||
| sh.exec('./node_modules/.bin/ng build --environment=production --silent'); | |||
| sh.exec(`node_modules${path.sep}.bin${path.sep}ng build --environment=production --silent`); | |||
There was a problem hiding this comment.
Why are you using that path, shouldn't sh.exec('ng build --silent'); be okay?
There was a problem hiding this comment.
You might not have ng installed globally, or not linked in your PATH.
There was a problem hiding this comment.
Yes, that is the reason. Now that you mention it, since the e2e tests run npm link, a simple ng build should work as well.
I'll make another PR to simply this.
|
LGTM. Closing this to unblock other PRs. |
clydin
pushed a commit
that referenced
this pull request
Jun 5, 2018
hansl
pushed a commit
that referenced
this pull request
Jun 6, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hansl @jkuri this should fix the broken test on appveyor.