chore: update tslint and codelyzer #3304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mgechev
commented
Nov 28, 2016
mgechev
commented
- Update to tslint ^4.0.2.
- Update to codelyzer 2.0.0-beta.1 which includes external templates & styles support.
- Drop deprecated tslint rules.
- Update to the latest rule changes in codelyzer.
mgechev
commented
Nov 28, 2016
| "component-selector-name": [true, "kebab-case"], | ||
| "directive-selector-type": [true, "attribute"], | ||
| "component-selector-type": [true, "element"], | ||
| "directive-selector": [true, "attribute", "<%= prefix %>", "camelCase"], |
There was a problem hiding this comment.
Note that a list of prefixes could be used, i.e.:
"directive-selector": [true, "attribute", ["<%= prefix %>", "bar", "baz"], "camelCase"]
deebloo
reviewed
Nov 29, 2016
| @@ -109,6 +101,8 @@ | |||
| "component-class-suffix": true, | |||
| "directive-class-suffix": true, | |||
| "templates-use-public": true, | |||
| "no-access-missing-member": true, | |||
| "templates-use-public": true, | |||
There was a problem hiding this comment.
"templates-use-public" is defined twice
1. Update to tslint ^4.0.2. 2. Update to codelyzer 2.0.0-beta.1 which includes external template support. 3. Drop deprecated tslint rules. 4. Update to the latest rule changes in codelyzer.
|
LGTM. |
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
1. Update to tslint ^4.0.2. 2. Update to codelyzer 2.0.0-beta.1 which includes external template support. 3. Drop deprecated tslint rules. 4. Update to the latest rule changes in codelyzer.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.