Skip to content

chore(e2e): fix early process exit to fail with error code 255 #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2016
Merged

chore(e2e): fix early process exit to fail with error code 255 #3049

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a2267c
chore(e2e): fix early process exit to fail with error code 255
hansl Nov 7, 2016
9bcae52
Merge branch 'master' into exitcode
hansl Nov 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/e2e_runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,18 @@ const argv = minimist(process.argv.slice(2), {
});


/**
* Set the error code of the process to 255. This is to ensure that if something forces node
* to exit without finishing properly, the error code will be 255. Right now that code is not used.
*
* When tests succeed we already call `process.exit(0)`, so this doesn't change any correct
* behaviour.
*
* One such case that would force node <= v6 to exit with code 0, is a Promise that doesn't resolve.
*/
process.exitCode = 255;


let currentFileName = null;
let index = 0;

Expand Down