chore(test): simplify test file #2839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
suggested changes
Nov 7, 2016
| @@ -14,21 +19,15 @@ declare var require: any; | |||
| // Prevent Karma from running prematurely. | |||
| __karma__.loaded = function () {}; | |||
|
|
|||
| // First, initialize the Angular testing environment. | |||
There was a problem hiding this comment.
Please surround this by try { ... } catch(err) { karma.error(err); } to catch potential framework errors and break the test.
There was a problem hiding this comment.
@hansl I tried throwing an error in a spec file (throw new Error('error here');) with and without the catch, and it's much better without it:
# with try/catch
kamik@T460p MINGW64 /D/sandbox/master-proj (master)
$ ng test --no-watch
09 11 2016 00:07:29.194:INFO [karma]: Karma v1.2.0 server started at http://localhost:9876/
09 11 2016 00:07:29.198:INFO [launcher]: Launching browser Chrome with unlimited concurrency
09 11 2016 00:07:29.280:INFO [launcher]: Starting browser Chrome
09 11 2016 00:07:30.590:INFO [Chrome 54.0.2840 (Windows 10 0.0.0)]: Connected on socket /#guzx9l6foj0Tw_5KAAAA with id 24284547
Chrome 54.0.2840 (Windows 10 0.0.0) ERROR
Chrome 54.0.2840 (Windows 10 0.0.0) ERROR
# without try/catch
kamik@T460p MINGW64 /D/sandbox/master-proj (master)
$ ng test --no-watch
09 11 2016 00:06:41.269:INFO [karma]: Karma v1.2.0 server started at http://localhost:9876/
09 11 2016 00:06:41.271:INFO [launcher]: Launching browser Chrome with unlimited concurrency
09 11 2016 00:06:41.279:INFO [launcher]: Starting browser Chrome
09 11 2016 00:06:42.600:INFO [Chrome 54.0.2840 (Windows 10 0.0.0)]: Connected on socket /#5bLXOqjWdAOdm5VyAAAA with id 53864020
Chrome 54.0.2840 (Windows 10 0.0.0) ERROR
Uncaught Error: error here
at webpack:///D:/sandbox/master-proj/src/app/app.component.spec.ts:35:0 <- src/test.ts:50522
Chrome 54.0.2840 (Windows 10 0.0.0) ERROR
Uncaught Error: error here
at webpack:///D:/sandbox/master-proj/src/app/app.component.spec.ts:35:0 <- src/test.ts:50522
filipesilva
force-pushed
the
remove-system-typing
branch
3 times, most recently
from
376c6c7 to
6025e99
Compare
|
Okay, as long as you say that the error was not inside a test but in the file itself. LGTM. |
|
I'll let you merge this. |
hansl
approved these changes
Nov 9, 2016
There is no need to have System typings or asynchronously load the testing modules.
filipesilva
force-pushed
the
remove-system-typing
branch
from
f135767 to
2328128
Compare
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
There is no need to have System typings or asynchronously load the testing modules.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to have System typings or asynchronously load
the testing modules.