refactor(@angular/cli): remove support for Node.js versions <18.19.1 and <20.11.1 #27249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
angular-robot
bot
added
detected: breaking change
alan-agius4
force-pushed
the
node-js-18
branch
6 times, most recently
from
3df5baa to
e525296
Compare
alan-agius4
commented
Mar 11, 2024
| (harness, setupTarget, isViteRun) => { | ||
| // TODO(fix-vite): currently this is broken in vite. | ||
| (isViteRun ? xdescribe : describe)('option: "allowedHosts"', () => { | ||
| (isViteRun ? xdescribe : xdescribe)('option: "allowedHosts"', () => { |
Collaborator
Author
There was a problem hiding this comment.
These tests just correctly return the page instead of failing.
https://github.com/angular/angular-cli/actions/runs/8232140697/job/22508914513?pr=27249
alan-agius4
added
the
action: review
Update ng-dev setup to work with 18.19 For more details, refer to: TypeStrong/ts-node#2094
alan-agius4
force-pushed
the
node-js-18
branch
3 times, most recently
from
eea9ac8 to
49958a8
Compare
…and <20.11.1 BREAKING CHANGE: Node.js support for versions <18.19.1 and <20.11.1 has been removed.
clydin
approved these changes
Mar 12, 2024
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Node.js support for versions <18.19.1 and <20.11.1 has been removed.