feat(@schematics/angular): replace assets with public directory
#27006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
alan-agius4
force-pushed
the
assets-public
branch
4 times, most recently
from
b2c7636 to
d700a88
Compare
alan-agius4
force-pushed
the
assets-public
branch
3 times, most recently
from
122714b to
3ebb099
Compare
alan-agius4
force-pushed
the
assets-public
branch
from
3ebb099 to
0f84ae9
Compare
alan-agius4
force-pushed
the
assets-public
branch
from
3270bc1 to
ab8bac4
Compare
markgoho
reviewed
Feb 17, 2024
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
assets-public
branch
from
ab8bac4 to
f776fe9
Compare
alan-agius4
force-pushed
the
assets-public
branch
9 times, most recently
from
1399e7f to
4b885db
Compare
The `assets` directory is confusing for the users and commonly users place "assets" which are not meant to be copied but instead processed by the build system. This causes some files both bundled and copied. With this change we rename the `assets` directory to `public` and also move the `favicon.ico` inside this newly created directory.
alan-agius4
force-pushed
the
assets-public
branch
from
4b885db to
c946a3e
Compare
clydin
approved these changes
Mar 25, 2024
alan-agius4
added
action: merge
|
This is not a good change. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assetsdirectory is confusing for the users and commonly users place "assets" which are not meant to be copied but instead processed by the build system. This causes some files both bundled and copied.With this change we rename the
assetsdirectory topublicand also move thefavicon.icoinside this newly created directory.