Skip to content

fix(serve): enable routes with dots #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2016
Merged

fix(serve): enable routes with dots #2535

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fd0bf3
fix(serve): enable routes with dots
filipesilva Oct 5, 2016
14fbc9c
Merge branch 'master' into enable-dot-rewrite
filipesilva Oct 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"typescript": "2.0.2",
"url-loader": "^0.5.7",
"webpack": "2.1.0-beta.25",
"webpack-dev-server": "2.1.0-beta.3",
"webpack-dev-server": "2.1.0-beta.9",
"webpack-md5-hash": "0.0.5",
"webpack-merge": "^0.14.0",
"zone.js": "^0.6.23"
Expand Down
2 changes: 1 addition & 1 deletion packages/angular-cli/custom-typings.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
interface IWebpackDevServerConfigurationOptions {
contentBase?: string;
hot?: boolean;
historyApiFallback?: boolean;
historyApiFallback?: {[key: string]: boolean} | boolean;
compress?: boolean;
proxy?: {[key: string]: string};
staticOptions?: any;
Expand Down
2 changes: 1 addition & 1 deletion packages/angular-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"typescript": "2.0.2",
"url-loader": "^0.5.7",
"webpack": "2.1.0-beta.25",
"webpack-dev-server": "2.1.0-beta.3",
"webpack-dev-server": "2.1.0-beta.9",
"webpack-md5-hash": "0.0.5",
"webpack-merge": "^0.14.0",
"zone.js": "^0.6.23"
Expand Down
4 changes: 3 additions & 1 deletion packages/angular-cli/tasks/serve-webpack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ export default Task.extend({
this.project.root,
`./${CliConfig.fromProject().config.apps[0].root}`
),
historyApiFallback: true,
historyApiFallback: {
disableDotRule: true,
},
stats: webpackDevServerOutputOptions,
inline: true,
proxy: proxyConfig,
Expand Down